🎨 Palette: Improve accessibility of camera metrics#25
🎨 Palette: Improve accessibility of camera metrics#25manupawickramasinghe wants to merge 1 commit intomainfrom
Conversation
- Added `tooltipText` to frame time and bitrate indicators in `fragment_camera.xml`. - Added new string resources for tooltips and verbose descriptions. - Updated `CameraFragment.kt` to set `contentDescription` dynamically for better screen reader experience. - Cleaned up duplicate attributes in `fragment_camera.xml`. This improves discoverability for mouse/stylus users and provides semantic context for screen reader users. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR enhances the accessibility and discoverability of the camera performance metrics (Frame Time and Bitrate).
Changes:
android:tooltipTextto theftFeedback(Frame Time) andqual_feedback(Bitrate) TextViews. This helps users understand what these numbers represent.CameraFragment.ktto programmatically set thecontentDescriptionof these TextViews when their values change. Instead of hearing "33ms", screen reader users will now hear "33 milliseconds latency".android:importantForAccessibilityandandroid:labelForattributes found infragment_camera.xmlduring the process.Why:
Previously, these metrics were just raw numbers without labels, making them confusing for new users and less accessible for screen reader users. This small polish aligns with the "Palette" philosophy of adding delightful micro-UX improvements.
Verification:
./gradlew assembleDebugsuccessfully.contentDescriptionis set using the validcontextfrom the BroadcastReceiver.PR created automatically by Jules for task 10999488797425543971 started by @manupawickramasinghe